Skip to content

Interstitial bareground - #1577

Draft
glemieux wants to merge 9 commits into
NGEET:mainfrom
glemieux:interstitial_bareground_option
Draft

Interstitial bareground#1577
glemieux wants to merge 9 commits into
NGEET:mainfrom
glemieux:interstitial_bareground_option

Conversation

@glemieux

@glemieux glemieux commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Changes how FATES handles "interstitial" bareground. Interstitial bareground in this context means the fraction of a given FATES patch area that is not covered by vegetation.

Description:

CLM associated pull request is ESCOMP/CTSM#4094

Relevant reference: CTSM technical note on MOST

Collaborators:

@ckoven @rgknox

Expectation of Answer Changes: Yes

Description of generative AI usage (as necessary)

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary
  • Describe use of generative AI (if necessary)

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided
  • FATES-CLM6 Code Freeze: satellite phenology regression tests are b4b

If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

glemieux added 2 commits June 14, 2026 14:54
This reflects that the output will be a fraction dependent on certain logic having to do with handling bareground
bare_frac_area = (1.0_r8 - local_patch_fraction) * &
(currentPatch%area/AREA)

total_patch_area = total_patch_area + bc_out(s)%canopy_fraction_pa(ifp) + bare_frac_area

@glemieux glemieux Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is dead and duplicate code being removed. total_canopy_area wasn't being used downstream.

Comment thread biogeochem/EDCanopyStructureMod.F90
Comment thread biogeochem/EDCanopyStructureMod.F90
@glemieux
glemieux force-pushed the interstitial_bareground_option branch 2 times, most recently from 389f7e8 to f8dc5ff Compare June 29, 2026 17:37
@glemieux
glemieux force-pushed the interstitial_bareground_option branch from f8dc5ff to c20ceb3 Compare July 28, 2026 17:14
@glemieux
glemieux force-pushed the interstitial_bareground_option branch 3 times, most recently from b121c49 to 4b58f2a Compare August 14, 2026 18:05
These are effectively dummy values that are necessary to avoid NaN calcs in on the HLM side
@glemieux
glemieux force-pushed the interstitial_bareground_option branch from 4b58f2a to 8c2b11c Compare August 14, 2026 23:12
@glemieux
glemieux force-pushed the interstitial_bareground_option branch from 4e8c950 to 4045b45 Compare August 24, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant